Skip to content

feat(select): add wrapper and bottom shadow parts #30951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thetaPC wants to merge 2 commits into
base: feature-8.8
Choose a base branch
from
Open

feat(select): add wrapper and bottom shadow parts #30951

thetaPC wants to merge 2 commits into from
+64 −3

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Feb 9, 2026 •
edited
Loading

Issue number: resolves #29918

What is the current behavior?

Developers can't customize elements within select like the bottom container because the component is a shadow component.

What is the new behavior?

  • Added bottom, wrapper, and wrapper-inner parts
  • Added a test

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@vercel
Copy link

vercel bot commented Feb 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment Feb 9, 2026 9:46pm

Request Review

@github-actions github-actions bot added the package: core @ionic/core package label Feb 9, 2026
@thetaPC thetaPC marked this pull request as ready for review February 9, 2026 21:55
@thetaPC thetaPC requested a review from a team as a code owner February 9, 2026 21:55
@thetaPC thetaPC requested a review from ShaneK February 9, 2026 21:55
ShaneK
ShaneK approved these changes Feb 10, 2026
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, the only minor concern I have is that there's no visual regression tests, but that's probably fine. No idea.

@thetaPC
Copy link
Contributor Author

thetaPC commented Feb 10, 2026

@ShaneK there's tests that check that the parts are working as intended.

@ShaneK
Copy link
Member

ShaneK commented Feb 10, 2026

@ShaneK there's tests that check that the parts are working as intended.

That is true, but in many other tests for parts we test with visual regression tests specifically. The fact tests existed at all is why I went ahead and approved and called it a minor concern.

@thetaPC
Copy link
Contributor Author

thetaPC commented Feb 10, 2026

@ShaneK there's tests that check that the parts are working as intended.

That is true, but in many other tests for parts we test with visual regression tests specifically. The fact tests existed at all is why I went ahead and approved and called it a minor concern.

That makes sense, but @brandyscarney has made good points of why we shifted over to use this new approach to test parts. I just can't seem to remember what it was. Maybe less snapshots for us to maintain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneK ShaneK ShaneK approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thetaPC @ShaneK